search

critto-bg / ImprovedAnvil

Improved Anvil, a mod for BG2:EE
http://forums.blackwyrmlair.net/index.php?showforum=99
5 stars 7 forks source link

Breach immunity for dragons via item and patch #14

Open bulian-bg opened 4 years ago

bulian-bg commented 4 years ago

Likely need to move/address IA dragons - Green Wyrm and Draco Ferrous, added here for reference

bulian-bg commented 4 years ago

Are you planning to adjust the other dragons here or just leave them in a separate pull request? At the very least, it makes sense to add the black dragon (nizi-something) here since he's patched programmatically (as I've pointed out in the comments inside the document) and you can easily equip these new boots on him.

do you have a preference from a maintenance perspective? the programatic approach seems preferable (easier to adjust scripts than .CRE files) which is why i coded it this way. assuming you agree, then the other pull request would just be dropped

bulian-bg commented 4 years ago

i created a new patch file for various modifications to IA creatures. this would require some changes elsewhere most likely. feel free to move the code as you see fit if there is a better spot. in general this may be useful if we ever want to patch large numbers of files, such as adjusting golem or skeleton XP.

also, it would be great to find a way to include the dragon fight since its already made. maybe we can fit in a small side quest within the druid stronghold as an excuse to include it.

critto-bg commented 4 years ago

Are you planning to adjust the other dragons here or just leave them in a separate pull request? At the very least, it makes sense to add the black dragon (nizi-something) here since he's patched programmatically (as I've pointed out in the comments inside the document) and you can easily equip these new boots on him.

do you have a preference from a maintenance perspective? the programatic approach seems preferable (easier to adjust scripts than .CRE files) which is why i coded it this way. assuming you agree, then the other pull request would just be dropped

Programmatic approach is absolutely more preferable. However, I am trying avoid mixing two styles. In other words: 1) if a vanilla resource was never rewritten in the first place, do everything programmatically 2) if a vanilla resource was overwritten as a part of the legacy approach, it's ok to edit the file and replace it. 3) IA resources are new by definition, it's OK to edit them directly by hand.

critto-bg commented 4 years ago

i created a new patch file for various modifications to IA creatures. this would require some changes elsewhere most likely. feel free to move the code as you see fit if there is a better spot. in general this may be useful if we ever want to patch large numbers of files, such as adjusting golem or skeleton XP.

also, it would be great to find a way to include the dragon fight since its already made. maybe we can fit in a small side quest within the druid stronghold as an excuse to include it.

It's OK, I'll adjust later. Just see my comment above about how I try to balance "rewriting vs. patching" issue.