search

critto-bg / ImprovedAnvil

Improved Anvil, a mod for BG2:EE
http://forums.blackwyrmlair.net/index.php?showforum=99
5 stars 7 forks source link

Extra encounters and forging for all protagonists #15

Closed bulian-bg closed 4 years ago

bulian-bg commented 4 years ago

well that take me about 3 hours, good thing nap time went long!

critto-bg commented 4 years ago

I'm 3/4 through your commit. Some bad news: pretty much none of it is written correctly, except for the simplest one-liners. When you do a REPLACE_TEXTUALLY, it does a verbatim search unless you use a regexp. Multi-liners aren't matched in none of your blocks. I'm having to rewrite this with regular expressions. Thankfully, it's pretty easy, but I still have to re-check each block to make sure.

Some things are just weird or missing crucial steps, I mention those in separate comments.

While I'm at it, I want to ask if you checked the dialogues with respective creatures involved in all of those quests you've made available for all protags. It's quite possible that some of the dialogues involve kit checks as well. I didn't look into it personally. I see that you've made replacements in crom/cespy dialogue, so I assume you did some searches through dialogues as well, but I ask anyway to be sure.

bulian-bg commented 4 years ago

yeah, not too surprising. i was pretty sure the syntax was incorrect. unfortunately, the scripts were complicated enough, particularly the planar sphere one, that simple deletions weren't possible. this is probably a case where just having a separate file for install would have been significantly simpler in the end

there are no class checks in the dialogues, fortunately.

critto-bg commented 4 years ago

I'm closing this one since you've pushed the patch into the appropriate repo.