critto-bg / ImprovedAnvil

Improved Anvil, a mod for BG2:EE
http://forums.blackwyrmlair.net/index.php?showforum=99
5 stars 7 forks source link

Fix animation handling. #31

Closed GraionDilach closed 1 year ago

GraionDilach commented 1 year ago

Revert animations to their Beamdog-allocated IDS names and slots to prevent random slot overwrite:

Use ANVIL animate.ids prefix, modder prefixes and dynamic allocation for animations not existing in the BG2EE animation array:

Included missing audio for animations:

Also deleted the IC_ICE_GOLEM reference, the EEs did away the IC prefix, the animation is listed as GOLEM_ICE on the platform.

References: https://www.gibberlings3.net/forums/topic/28835-toss-your-semi-useful-weidu-macros-here/page/2/#comment-254894 https://github.com/GwendolyneFreddy/Infinity-Animations/tree/master/infinityanimations/documentation

GraionDilach commented 1 year ago

@critto-bg @SparrowJacek Is the SKELETON_LORD transparency effect intentional? Because ANIMATED_PLATE_BRONZE lacks and never intended that. It comes from the GHOST animation INI setup.

If it is intended, I'll set up the PR so that it assigns a custom IWD animation slot for the variant.

EDIT: Decided to just keep the status quo on this one.

SparrowJacek commented 1 year ago

Thank you very much for your help! I will analyze your changes and hopefully understand how to operate in the future. I don't think that transparency effect was intended, I am not not even sure how it was achieved.

In general I was just happy that my attempts at introducing animations from other IE games succeeded, I never dug deeper to understand how to introduce them properly. And it was all around 7 years ago, so forgot all about it...

GraionDilach commented 1 year ago

I'm done with the cleanup. This is ready for review.

critto-bg commented 1 year ago

Finally found the time to check and review this (thanks to @SparrowJacek for the help). The worg and the goblin shaman animations will be used in the upcoming v7 contents.

Transparency seems to be an unintended side effect that ended up being released as a feature. We'll probably fix it even though nobody seemed to mind it since the change had been introduced.

Once again, thanks for the help.