search

critto-bg / ImprovedAnvil

Improved Anvil, a mod for BG2:EE
http://forums.blackwyrmlair.net/index.php?showforum=99
5 stars 7 forks source link

Update Chinese translation to 7.0 by windmilladventure001 #37

Closed MephistoSatanDevil closed 1 month ago

MephistoSatanDevil commented 1 month ago

https://github.com/critto-bg/ImprovedAnvil/pull/36#issuecomment-2277168617

critto-bg commented 1 month ago

Can you omit the weidu update, please? It needs to be done and tested separately. Thanks.

MephistoSatanDevil commented 1 month ago

Can you omit the weidu update, please? It needs to be done and tested separately. Thanks.

done.

In fact, when an updated version of weidu.exe exists in the game directory, the file will automatically upgrade itself before installation. So, if there were issues with updating weidu, someone might have already reported the issue. LOL

critto-bg commented 1 month ago

Thanks. Yeah, I know about the auto-update thing. Even if everything is fine, I prefer not to mix together different things within one commit. I'll update the weidu separately when I publish a small update, hopefully, this or next week. I'll merge the support for Chinese language into it as well.

MephistoSatanDevil commented 1 month ago

Thanks. Yeah, I know about the auto-update thing. Even if everything is fine, I prefer not to mix together different things within one commit. I'll update the weidu separately when I publish a small update, hopefully, this or next week. I'll merge the support for Chinese language into it as well.

Thank you. In fact, we update Weidu.exe because the UTF-8 encoded Chinese console prompts would become garbled under the old version of weidu.exe. The latest version of weidu.exe has resolved this issue, so Chinese modders often update weidu.exe to version 24900 when localizing mods at present.

Some people have discussed this: https://github.com/The-Gate-Project/DarkHorizons/pull/23 This is another related discussion: https://github.com/BGforgeNet/bg2-wildmage/issues/30

So updating Weidu.exe is also part of the translation process.

critto-bg commented 1 month ago

Understood. I was not aware of this issue. In any case, updating weidu might have some unintended other effect as the result of changes made to the executable. I will need to review what's been done to weidu and make sure there is nothing potentially problematic for us.