crkn-rcdr / cap

Public front-end for the Canadiana Access Platform
https://www.canadiana.ca
0 stars 0 forks source link

Removing "item_mode" of "pdf" #162

Closed RussellMcOrmond closed 9 months ago

RussellMcOrmond commented 1 year ago

Related to #161 , but lower priority (as developers bump into the relevant code).

A document has an "item_mode" attribute: https://github.com/crkn-rcdr/cap/blob/2f940c59528004769fdd862067e6050f33725ad1/CAP/lib/CIHM/Access/Presentation/Document.pm#L43-L46

We'll want to get rid of the returning of "pdf", and look at any code that that different things depending on the value of item_mode.

Check what returning "" and "noid" means, and if those are important to retain.