crkn-rcdr / cihm-metadatabus

Documentation and Docker build environment for key portions of the metadata bus.
BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Hammer: Include slug with noid for "not found in Search documents"? #91

Closed RussellMcOrmond closed 1 year ago

RussellMcOrmond commented 1 year ago

Related to https://github.com/crkn-rcdr/Access-Platform/issues/600 and https://github.com/crkn-rcdr/Access-Platform/issues/524

RussellMcOrmond commented 1 year ago

Currently Hammer will generate messages when a noid in a collection isn't in a search document:

2023/05/09 09:49:10 - WARN {CIHM.TDR} [CIHM::Meta::Hammer2::Worker::warnings] 69429/g0sj19k46427: Noids not found in Search documents: 69429/m05d8nc5z97w 69429/m0w08w955v9c

This references 3 noids:

The problem was that the collection oocihm.8_02182 was processed before oocihm.8_02182_1 and oocihm.8_02182_2 had been approved and processed. Once oocihm.8_02182 was processed again, the problem was resolved.

In other cases, the message lingers because the member of the collection is never approved, or alternatively removed from the collection (something that isn't intended to be approved should not remain in the collection).

My guess is that staff aren't cleaning these up because they don't find it easy to translate noids to slugs. I regularly paste noids into the URL (Like I did above for the 3 links to the editor), but maybe that isn't something other staff does?

An additional solution beyond what is discussed in the other two tickets is to update Hammer to do a noid to slug lookup and display the slug along with the noid in the error message.