SaschaAdler
commented
4 years ago This is a very cool start. A few things I can think of off the bat:
- the slug resolver no longer works because the API calls have changed. This isn't in scope of the current PR but you'll have a hard time actually finding collections to work on. Things look good with this one.
- id shouldn't be editable
- the slug field should be checking the collection slug API calls to figure out if a new slug is good. of course, for this to work you need to keep track of the slug you started off with, since that's still valid
- the IIIF text editor is a bit overwrought. I think the Language and Value headers can show up above the already existing language-value pairs, and that both the existing pairs and the entry for new pairs should line up in the same element. The table isn't a bad idea but should be used for the whole component. You should also be able to clear existing values.
- ordered can be a checkbox
- public shouldn't be editable. I might change this to the date instead of a boolean
- try moving the items list to the right side of the page. I'll have more thoughts about what should actually be displayed but I imagine it can get a bit more compact
- here's a collection with parents. You'll need to expand the objects you get in the list.
DivyaKrishnan26
To get a look at the collection record(unordered)