search

crnk-project / crnk-framework

JSON API library for Java
Apache License 2.0
284 stars 153 forks source link

@crnk/ngrx-json incompatible with @ngrx/effects v7+ #674

Open gianinbasler opened 4 years ago

gianinbasler commented 4 years ago

In crnk.operations.effects.ts @Effect() applyResources$ = this.actions$.ofType(NgrxJsonApiActionTypes.API_APPLY_INIT) is used. However, since @ngrx/effects v7, the ofType method must be used as follows: @Effect() applyResources$ = this.actions$.pipe(ofType(NgrxJsonApiActionTypes.API_APPLY_INIT), See ngrx V7 Update Guide for details.

Because of this, we cannot update our ngrx dependencies to a newer version than 6.1.2.

Could you please update your the crnk ngrx-json library to support ngrx v7+?

gianinbasler commented 4 years ago

Created PR with necessary changes, see https://github.com/crnk-project/crnk-framework/pull/675.