crnormand / gurps

Implementing a GURPS 4e game aid for Foundry VTT
MIT License
105 stars 49 forks source link

[Bug] Attack Modes on Duplicated Items Don't Get the New Name #1347

Open engurrand opened 2 years ago

engurrand commented 2 years ago

Let's start with an item, say a Concussion Grenade, with two attack modes for throwing it and for blowing it up. The ranged attack table on the character record will list,

Concussion Grenade ....Throw data data data Concussion Grenade ....Explode data data data

Now if you duplicate that item in your gear tab and change the new item's name to Fragmentation Grenade, then add a third attack mode adding fragmentation damage, you will find that no mater what character record you add that gear to, even if the other record is otherwise empty, its attack table will list:

Concussion Grenade ....Throw data data data Concussion Grenade ....Explode data data data Fragmentation Grenade ...Fragmentation data data data

This is incorrect, it should read Fragmentation Grenade for all three entries.

It would seem that whatever function gets the name for the leftmost column in the attack modes list, that is the name of the gear itself, only triggers when the attack mode is created? I haven't found any workaround other than building each new item from scratch.

crnormand commented 2 years ago

I think this is an Item design issue. Each Item traces back to the original Item created by the GM... even if you change its name. I will have to look into this to see I can remove that without breaking anything else.