search

crnormand / gurps

Implementing a GURPS 4e game aid for Foundry VTT
MIT License
98 stars 44 forks source link

Tokens don't display Combat Maneuvers #1918

Closed giggioz closed 3 days ago

giggioz commented 3 weeks ago

Version 0.17.3 I noticed a couple of things, first: When you mark a token as defeated (in combat) on the canvas there is no any icon to show it. as you can see Colba is defeated but the canvas token does not show it (probably related to #1909)

image

Second thing: if i select a maneuver from the token menù (same thing if i use the character sheet) it does not show it in the canvas, as you can see Akrul has an attack maneuver but it is now shown

image

Extra info: i reloaded the world because i added a new module and at least the manevuer icons are shown (pix1), but if i select another maneuver it disappears as before (pix2)

image image

Gravydigger commented 3 weeks ago

In addition to this, when moving to another tokens turn, the Maneuver also vanishes from the combat tracker.

Setting Maneuver on a tokens turn: 1 Moving to the next tokens turn 2

Farmeroz commented 3 weeks ago

Adding to this on behalf of a Discord user without a GitHub account (discussed in https://discord.com/channels/228546929494065152/788878698349723669 ).

Similar issues, and some errors from the console that might help - see images. image

This one when right clicking:

image

image

User advised this was with all modules disabled, V12, 0.17.3.

giggioz commented 3 weeks ago

imagethis was the culprit!

The flag was set to None. I have now set it to Everyone and it works.

However, I believe there is some strange behavior when this flag is set to None.

For example when foundry restarts the icons are visible and instead they should not be.

crnormand commented 3 days ago

As of Foundry 12.328, the maneuver icons no longer throw exceptions when set to "None". Also, they seem to stay associated with each token, as the combat tracker changes.

However, it does throw an exception when the status is set to "dead":

Uncaught (in promise) Error: Invalid status ID "dead" provided to Actor#toggleStatusEffect
    at GurpsActor.toggleStatusEffect (foundry.js:15878:26)
    at CombatTracker._onToggleDefeatedStatus (foundry.js:90211:28)

So the question becomes... why isn't "dead" a valid status? ;-) I'm still investigating this.

crnormand commented 3 days ago

Ok, found it. I've hacked the effects list to include 'dead' so it can be set (and displayed) from the combat tracker.