crnormand / gurps

Implementing a GURPS 4e game aid for Foundry VTT
MIT License
102 stars 49 forks source link

Import of equipment files fails with blank damage field #1927

Closed Battenhatch closed 2 weeks ago

Battenhatch commented 1 month ago

I have encountered an issue in GGA v 0.17.4 on both v11 and v12, on Forge and in a local server, with no modules active, where - as I read the error message - an attempt to read the blank damage field in the Smoke Grenade item in the Basic Set causes the process to fail.

crnormand commented 1 month ago

I can't find a "Smoke Grenade" in the Basic Set library of GCS. Can you upload your character .gcs file?

Battenhatch commented 1 month ago

Ah, sorry, in the Basic Set it's the "Hand Grenade, Stun" item.

I've been tinkering further, and a recreation of the item has solved it, but only AFAICT, because there is now something in the damage field, namely the damage type "cr" (no +xd notation, though, just the "cr" damage type). When the item looks like this, the process runs as intended. But there seems to be something about an emty damage field that the system doesn't like. This has been seen on v11 (GGA 0.16.10) also.

mjeffw commented 2 weeks ago

I have a fix for this.