Network firewall page is not the way it should be

[GoogleCodeExporter]

What steps will reproduce the problem?
1.Go to Network/firewall
2.See the page as attached in image(xwrt_issue.jpg)
3. After you press add on this page, it takes you nowhere, Result is in
attachment. (xwrt_output.jpg)

This is from latest trunk from xwrt(i.e revision 4871).

What is the expected output? What do you see instead?
It should be firewall setting options, with input boxes, where we can
configure ports, I/P, O/P IP address, Port forwarding, Port triggering and all.

What version of the product are you using? On what operating system and web
browser?

Please provide any additional info below.

Original issue reported on code.google.com by sahilmakkar1983@gmail.com on 22 Mar 2010 at 2:22

[GoogleCodeExporter]

The firewall page you have displayed there is not from trunk. I don't know what
version you are using being it looks like it has been customized. The old 
firewall
page no longer works in trunk. (hasn't for some time)

Original comment by kemen04@gmail.com on 22 Mar 2010 at 5:23

[GoogleCodeExporter]

Only image I have changed and some options I have just disabled, no script 
changes
exactly. This is from trunk only, Can you paste latest network-firewall.sh here.

I am attaching mine network-firewall.sh.

Also, one more thing what I have noticed is - this file tries to parse
/etc/config/firewall to get values be displayed around input boxes, but the way 
its
parsing will never succeed.

Original comment by sahilmakkar1983@gmail.com on 23 Mar 2010 at 6:17

Attachments:

• network-firewall.sh

[GoogleCodeExporter]

Just to clarify what I am doing:

X-WRT Version from Trunk  without any customization - revision 4871
With this version, The following pages are displayed - xwrt_1st.jpg and 
xwrt_issue.jpg. 

The way the parsing of /etc/config/firewall is done in network-firewall.sh, it 
seems
that, it will not work. 

Refer line number 265 in network-firewall.sh
<<
(\$1 == "drop") || (\$1 == "accept") || (\$1 == "forward" ) { 
>>

I have  attached the network-firewall.sh that I am using from trunk along with 
the
Firewall HTML page.

It would be good if you could let me know, how I could get  the X_WRT Firewall 
page
from Trunk working. Am I missing something? 

Thanks

Original comment by sahilmakkar1983@gmail.com on 23 Mar 2010 at 7:27

Attachments:

• xwrt_1st.jpg
• xwrt_issue.jpg
• network-firewall.sh

[GoogleCodeExporter]

Again, you are not checking out trunk, the firewall page for trunk is
http://code.google.com/p/x-wrt/source/browse/trunk/package/webif/files/www/cgi-b
in/webif/network-firewall.sh

Original comment by kemen04@gmail.com on 23 Mar 2010 at 1:04

[GoogleCodeExporter]

Can you please provide check out path.
I didn't find proper path anywhere, some paths are read only.

Original comment by sahilmakkar1983@gmail.com on 23 Mar 2010 at 1:09

[GoogleCodeExporter]

Got the link, thanks

Original comment by sahilmakkar1983@gmail.com on 23 Mar 2010 at 1:16

[GoogleCodeExporter]

Original comment by kemen04@gmail.com on 23 Mar 2010 at 3:14

• Changed state: Invalid