croberts22 / myanilist-bugs

A public repository containing bug reports for MyAniList.
5 stars 0 forks source link

Search incorrectly keeps its own section collapse state #58

Closed seanblue closed 2 years ago

seanblue commented 2 years ago

Possibly related to changes made for #55.

As of the current beta, tapping the search bar on the Anime tab (presumably the Manga tab too) may auto-expand all of the sections. I found this odd, so I closed them (seeming to show that #55 was fixed). The problem is, when I then typed something into the search bar, the result was behind a collapsed section. It used to auto-expand the section(s) that had search results. What seems to be happening is that the expand/collapse state is saved separately for when the search box is selected and for when it's not. I find this really confusing. Ideally, this should be the behavior:

croberts22 commented 2 years ago

Thanks for the feedback here @seanblue! This is a regression that was caused from some of the improvements I was making here with updates. I think what you mentioned is pretty much what the previous behavior was. There are effectively two states that I'm keeping track of (your actual display preferences versus the preferences shown in search), and I think it makes sense to default to showing your display preferences up until you start typing something. From there on, it will auto-expand any section that has series that match the search query.