search

croberts22 / umalapi

DEPRECATED, moved to project railgun: The unofficial API for MyAnimeList.net.
4 stars 1 forks source link

Bug: Alternative titles split by comma even when it is part of the title #14

Open seanblue opened 9 years ago

seanblue commented 9 years ago

Unfortunately there is no separation of titles within a section (such as "synonyms") by DOM element, so it's not possible to differentiate between commas as part of the title and commas used as a separator.

However, for the English title there is only expected to be one title. Therefore, this issue could be fixed for just the English title by not splitting the text by comma and just returning a single-element array.

seanblue commented 9 years ago

For example: http://myanimelist.net/anime/14741/Chuunibyou_demo_Koi_ga_Shitai! http://umal-api.coreyjustinroberts.com/1.1/anime/14741

croberts22 commented 9 years ago

Nice catch! I'll make a note of this and try to get this fixed soon. Optionally, if you have a pull request ready, I can take a look at it. 

Thanks!

On Thu, Aug 6, 2015 at 5:43 PM, seanblue notifications@github.com wrote:

Unfortunately there is no separation of titles within a section (such as "synonyms") by DOM element, so it's not possible to differentiate between commas as part of the title and commas used as a separator.

However, for the English title there is only expected to be one title. Therefore, this issue could be fixed for just the English title by not splitting the text by comma and just returning a single-element array.

Reply to this email directly or view it on GitHub: https://github.com/croberts22/umalapi/issues/14