search

crobertsbmw / deckofcards

An API to simulate a deck of cards
MIT License
1.34k stars 335 forks source link

Consider using deck size #21

Closed vladegikyan closed 8 years ago

vladegikyan commented 9 years ago

Hello, I am looking for such API as yours and I have an idea of a game. Though, there are games that use less then 52 cards in the deck. I think that it will be reasonable to add maybe optional deck_size parameter to /deck/new/

crobertsbmw commented 9 years ago

This issue has already been address. See this: http://deckofcardsapi.com/#partial-deck

vladegikyan commented 9 years ago

Yes, but it is not usable at all to pass 36 or 32 cards. Why not to pass just number?

On Thu, May 21, 2015 at 10:26 PM Chase Roberts notifications@github.com wrote:

This issue has already been address. See this: http://deckofcardsapi.com/#partial-deck

— Reply to this email directly or view it on GitHub https://github.com/crobertsbmw/deckofcards/issues/21#issuecomment-104394717 .

crobertsbmw commented 9 years ago

So which ones would the api remove? Do you want a deck of 32 random cards? If that's the case, you could just draw 4 cards and then ignore them.

On Thu, May 21, 2015 at 1:34 PM, vladegikyan notifications@github.com wrote:

Yes, but it is not usable at all to pass 36 or 32 cards. Why not to pass just number?

On Thu, May 21, 2015 at 10:26 PM Chase Roberts notifications@github.com wrote:

This issue has already been address. See this: http://deckofcardsapi.com/#partial-deck

— Reply to this email directly or view it on GitHub < https://github.com/crobertsbmw/deckofcards/issues/21#issuecomment-104394717

.

— Reply to this email directly or view it on GitHub https://github.com/crobertsbmw/deckofcards/issues/21#issuecomment-104396701 .