search

crobertsbmw / deckofcards

An API to simulate a deck of cards
MIT License
1.34k stars 335 forks source link

AD.png still returns a CORS error #55

Closed donbraffitt closed 6 years ago

donbraffitt commented 6 years ago

I've got 51 of the 52 cards now loading correctly. Just one still returns a CORS error at test-cors.org:

https://deckofcardsapi.com/static/img/AD.png

Don

crobertsbmw commented 6 years ago

Interesting. I added a blanket nginx cors header for everything in the /static/ folder. So I don't know why it wouldn't be working for that one. One other thing of note is that the api doesn't return AD.png but rather return aceDiamonds.png because ad blockers like to think that AD.png is an advertisement rather than the ace of diamonds. Maybe that's somehow related?

donbraffitt commented 6 years ago

Maybe that's somehow related?

Yes. When I changed my code to use

https://deckofcardsapi.com/static/img/aceDiamonds.png

for that 1 card, all 52 cards now load fine.

Thanks again.

Don

From: Chase Roberts notifications@github.com Reply-To: crobertsbmw/deckofcards reply@reply.github.com Date: Friday, October 19, 2018 at 3:54 PM To: crobertsbmw/deckofcards deckofcards@noreply.github.com Cc: Don Braffitt don@willbraffitt.org, Author author@noreply.github.com Subject: Re: [crobertsbmw/deckofcards] AD.png still returns a CORS error (#55)

Interesting. I added a blanket nginx cors header for everything in the /static/ folder. So I don't know why it wouldn't be working for that one. One other thing of note is that the api doesn't return AD.png but rather return aceDiamonds.png because ad blockers like to think that AD.png is an advertisement rather than the ace of diamonds. Maybe that's somehow related?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.