search

crocodile2u / chainy

29 stars 3 forks source link

Make chains immutable #5

Closed urmaul closed 5 years ago

urmaul commented 5 years ago

You could add immutability easily by making add() return new instance of chain instead of $this.

crocodile2u commented 5 years ago

Hmm, that's definitely an option! And it does not look like a BC break at all! I hope I'll have time to get to chainy on weekend!

чт, 15 нояб. 2018 г. в 15:03, Bogdan Kolbik notifications@github.com:

You could add immutability easily by making add() return new instance of chain instead of $this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/crocodile2u/chainy/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ABqAdLqfb82XEmjs0KR5Sh_Kdrgy_xz1ks5uvXRDgaJpZM4Yf29Y .

crocodile2u commented 5 years ago

https://github.com/crocodile2u/chainy/pull/7