crocovert / networks

GNU General Public License v3.0
19 stars 3 forks source link

Please remove binary files #6

Closed pcav closed 5 years ago

pcav commented 5 years ago

This is not acceptable for a public plugin, who should contain only free and open source code. Thanks.

crocovert commented 5 years ago

Hello Paolo Sorry if I have misunderstood, but the executable source code is put on my GitHub page and he is with the plugin only since version 2.1 Is it non acceptable if the source code is available in my GitHub page, and if  can you only unapproved version 2.1 and after, I will then put a new version without the executable Thanks for your answer Best regards Patrick Palmier Le 3 oct. 2018 18:17, "> Paolo Cavallini (par Internet, dépôt bounces+848413-5eca-patrick.palmier=cerema.fr@sgmail.github.com)" notifications@github.com a écrit :This is not acceptable for a public plugin, who should contain only free and open source code. Thanks.

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/crocovert/networks","title":"crocovert/networks","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/crocovert/networks"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Please remove binary files (#6)"}],"action":{"name":"View Issue","url":"https://github.com/crocovert/networks/issues/6"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/crocovert/networks/issues/6", "url": "https://github.com/crocovert/networks/issues/6", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Please remove binary files (#6)", "sections": [ { "text": "", "activityTitle": "Paolo Cavallini", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@pcav", "facts": [ { "name": "Repository: ", "value": "crocovert/networks" }, { "name": "Issue #: ", "value": 6 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"crocovert/networks\",\n\"issueId\": 6,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"crocovert/networks\",\n\"issueId\": 6\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/crocovert/networks/issues/6" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387548294\n}" } ], "themeColor": "26292E" } ]

pcav commented 5 years ago

Hi Partick,

I unapproved it just as an "emercency" measure. I have very little time now, so I can't really analyse the issue in depth (I can do it next week).

It would greatly help if you could explain me the situation inmore detail.

Thanks a lot, and sorry for the rush.

All the best.

Il 10/03/2018 06:51 PM, crocovert ha scritto:

Hello Paolo Sorry if I have misunderstood, but the executable source code is put on my GitHub page and he is with the plugin only since version 2.1 Is it non acceptable if the source code is available in my GitHub page, and if  can you only unapproved version 2.1 and after, I will then put a new version without the executable Thanks for your answer Best regards Patrick Palmier Le 3 oct. 2018 18:17, "> Paolo Cavallini (par Internet, dépôt bounces+848413-5eca-patrick.palmier=cerema.fr@sgmail.github.com)" notifications@github.com a écrit :This is not acceptable for a public plugin, who should contain only free and open source code. Thanks.

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/crocovert/networks","title":"crocovert/networks","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/crocovert/networks"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Please remove binary files (#6)"}],"action":{"name":"View Issue","url":"https://github.com/crocovert/networks/issues/6"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/crocovert/networks/issues/6", "url": "https://github.com/crocovert/networks/issues/6", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Please remove binary files (#6)", "sections": [ { "text": "", "activityTitle": "Paolo Cavallini", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@pcav", "facts": [ { "name": "Repository: ", "value": "crocovert/networks" }, { "name": "Issue #: ", "value": 6 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"crocovert/networks\",\n\"issueId\": 6,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"crocovert/networks\",\n\"issueId\": 6\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/crocovert/networks/issues/6" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387548294\n}" } ], "themeColor": "26292E" } ]

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/crocovert/networks/issues/6#issuecomment-426712191, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqOgt1sCGxnsGuKKotIRao920pp3Vnnks5uhOsBgaJpZM4XGYSG.

-- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/

crocovert commented 5 years ago

Hi Paolo,

Here is an history of the plugin: Until version 2, the plugin is in a classic plugin (no algorithmprovider and contains only Python source code, no binary) Following your recommandations to propose plugin functionnalities as an algorithm provider, I released the plugin functionnalities as an algorithm provide Before version 2.1.0 the is only python source algorithms (no binary) In version 2.1.0 I have introduced an algorithm that calls a binary (Muslic.exe) that compute multimodal routing.

This plugin developped in C# is open source. The open source code is located in my github repository https://github.com/crocovert/muslic

This executable is a console program developped in c# .NET with Monodevelop (Free developement tool)

The executable is opensource and runs on Windows and on Linux with MonoRuntime (opensource)

If it's acceptable to add an executable opensource (source on github https://github.com/crocovert/muslic) please can you approve the plugin. If it's not acceptable, tell me and I will remove the binary file from the plugin and the corresponding algorithm and please approve the versions without the binary file (before 2.10)

If you have more specific question, please contact meand I will answer you as soon as possible

Thanks

Best regards


PATRICK PALMIER Responsable du groupe Systèmes de Transport et Sécurité Département Transport et Mobilités CEREMA - Direction territoriale Nord Picardie 44 ter rue Jean Bart CS20275 59019 LILLE cedex Tél: 03 20 49 60 70 Mob: 07 74 34 25 07

Le 03/10/2018 18:53, > Paolo Cavallini (par Internet, dépôt bounces+848413-5eca-patrick.palmier=cerema.fr@sgmail.github.com) a écrit :

Hi Partick,

I unapproved it just as an "emercency" measure. I have very little time now, so I can't really analyse the issue in depth (I can do it next week).

It would greatly help if you could explain me the situation inmore detail.

Thanks a lot, and sorry for the rush.

All the best.

Il 10/03/2018 06:51 PM, crocovert ha scritto:

Hello Paolo Sorry if I have misunderstood, but the executable source code is put on my GitHub page and he is with the plugin only since version 2.1 Is it non acceptable if the source code is available in my GitHub page, and if can you only unapproved version 2.1 and after, I will then put a new version without the executable Thanks for your answer Best regards Patrick Palmier Le 3 oct. 2018 18:17, "> Paolo Cavallini (par Internet, dépôt bounces+848413-5eca-patrick.palmier=cerema.fr@sgmail.github.com)" notifications@github.com a écrit :This is not acceptable for a public plugin, who should contain only free and open source code. Thanks.

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/crocovert/networks","title":"crocovert/networks","subtitle":"GitHub

repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in

GitHub","url":"https://github.com/crocovert/networks"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Please remove binary files (#6)"}],"action":{"name":"View Issue","url":"https://github.com/crocovert/networks/issues/6"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/crocovert/networks/issues/6", "url": "https://github.com/crocovert/networks/issues/6", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Please remove binary files (#6)", "sections": [ { "text": "", "activityTitle": "Paolo Cavallini", "activityImage":

"https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@pcav", "facts": [ { "name": "Repository: ", "value": "crocovert/networks" }, { "name": "Issue #: ", "value": 6 } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"crocovert/networks\",\n\"issueId\": 6,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"crocovert/networks\",\n\"issueId\": 6\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/crocovert/networks/issues/6" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387548294\n}" } ], "themeColor": "26292E" } ]

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub

https://github.com/crocovert/networks/issues/6#issuecomment-426712191, or mute the thread

https://github.com/notifications/unsubscribe-auth/AAqOgt1sCGxnsGuKKotIRao920pp3Vnnks5uhOsBgaJpZM4XGYSG.

-- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/

-- You are receiving this because you commented. Reply to this email directly, view it on GitHub [1], or mute the thread [2].

Links:

[1] https://github.com/crocovert/networks/issues/6#issuecomment-426712965 [2] https://github.com/notifications/unsubscribe-auth/AJHAYaTaXBC1qxRgEszV0cWOl2Him77Oks5uhOuKgaJpZM4XGYSG

pcav commented 5 years ago

Thanks for the clarification. I have published all versions pre 2.1.0. As for the exe issue, I'm unsure which one is the best route. Could you please open a discussion on this on qgis-dev? Thanks.

pcav commented 5 years ago

Could you please remove versions with the exe embedded, so we can keep the queue of unapproved plugins clean? Thanks.

crocovert commented 5 years ago

Ok It's done