search

crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
12 stars 8 forks source link

Rename CommonCriteria files -> cc #287

Closed adamjanovsky closed 1 year ago

adamjanovsky commented 1 year ago

Filenames of common_criteria*.py should be renamed to cc*.py.

@J08nY Would you like to rename also classes? E.g. CommonCriteriaCert to CCCertificate? We're not consistent there as well.

adamjanovsky commented 1 year ago

@J08nY what do you think about CommonCriteriaCert -> CCCertificate? Three Cs in a row seem a lot :D But we have CCDataset, FIPSDataset, FIPSCertificate, and then we have CommonCriteriaCert ...

J08nY commented 1 year ago

Go for it.

Special cases aren't special enough to break the rules.

  • Zen of Python
adamjanovsky commented 1 year ago

PEP 8 strikes back 😆

A Foolish Consistency is the Hobgoblin of Little Minds

J08nY commented 1 year ago

I would still go for it CCCertificate is not unreadable I think.