search

crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
9 stars 7 forks source link

Add codecov #292

Closed J08nY closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@846144e). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #292 +/- ## ======================================= Coverage ? 73.25% ======================================= Files ? 45 Lines ? 5580 Branches ? 0 ======================================= Hits ? 4087 Misses ? 1493 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adamjanovsky commented 1 year ago

@J08nY Can this be incorporated also into local development? I.e. can we create a pre-commit task for this? It's uncomfortable to discover failing pipelines only when they get to remote.

J08nY commented 1 year ago

Well you can track code coverage when running tests. I do not think it makes sense to include anything based on that to a pre-commit. Otherwise every commit would run the test suite, I think that should not happen and be separate. If you want to look at the coverage diff you can check codecov manually, or just push and see the pipeline results.