crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
12 stars 8 forks source link

Feat cpe configurations #300

Closed GeorgeFI closed 1 year ago

GeorgeFI commented 1 year ago

Closes #252

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 55.68% and project coverage change: -1.13 :warning:

Comparison is base (c0084cf) 74.23% compared to head (21b88b0) 73.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #300 +/- ## ========================================== - Coverage 74.23% 73.09% -1.13% ========================================== Files 45 45 Lines 5606 5629 +23 ========================================== - Hits 4161 4114 -47 - Misses 1445 1515 +70 ``` | [Impacted Files](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni) | Coverage Δ | | |---|---|---| | [src/sec\_certs/utils/pandas.py](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy91dGlscy9wYW5kYXMucHk=) | `0.00% <0.00%> (ø)` | | | [src/sec\_certs/sample/cve.py](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9zYW1wbGUvY3ZlLnB5) | `51.79% <39.69%> (+2.75%)` | :arrow_up: | | [src/sec\_certs/sample/cpe.py](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9zYW1wbGUvY3BlLnB5) | `91.14% <85.72%> (-1.28%)` | :arrow_down: | | [src/sec\_certs/dataset/cve.py](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9kYXRhc2V0L2N2ZS5weQ==) | `61.44% <87.50%> (-31.61%)` | :arrow_down: | | [src/sec\_certs/dataset/dataset.py](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9kYXRhc2V0L2RhdGFzZXQucHk=) | `61.42% <100.00%> (-2.93%)` | :arrow_down: | | [src/sec\_certs/sample/\_\_init\_\_.py](https://codecov.io/gh/crocs-muni/sec-certs/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9zYW1wbGUvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://codecov.io/gh/crocs-muni/sec-certs/pull/300/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adamjanovsky commented 1 year ago

@GeorgeFI finalized my checks and we're good for merge 🎉 , thank you for your effort 👍.

Few thinks I've adjusted: