Closed adamjanovsky closed 8 months ago
Attention: 675 lines
in your changes are missing coverage. Please review.
Comparison is base (
f0f7fa7
) 74.61% compared to head (68b1c2d
) 67.80%.:exclamation: Current head 68b1c2d differs from pull request most recent head b648241. Consider uploading reports for the commit b648241 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Just a quick comment on the current state of affairs:
sec_certs.model.references_nlp
package that has some complex dependencies. Any import from that package requires sec-certs
installation with [nlp]
extra. A check is done on any import from that package.nlp
deps are also installed on dev machines -- otherwise, linters will likely complain
This PR adds models to annotate references.
Things to resolve:
billiard
tomultiprocessing
, check that we're ok with thatTest that the annotator works in production.[nlp]
and guards or keep them in ordinary requirements.Actually callannotate_references()
from somewhere. Probably fromanalyze_certificates()
?As a byproduct, this closes #256