search

crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
9 stars 7 forks source link

Replace subprocess.call in OCR with pytesseract library #335

Closed adamjanovsky closed 8 months ago

adamjanovsky commented 1 year ago

As we generally try to avoid subprocess.run(), it would be good idea to replace the OCR-related calls with a Python wrapper for tesseract.

This concerns refactoring the following snippet

https://github.com/crocs-muni/sec-certs/blob/b808490207666abf0e4afc97305d05ca9facc0fa/src/sec_certs/utils/pdf.py#L40-L70

@J08nY just for your reference

GeorgeFI commented 9 months ago

@adamjanovsky Hi, I am taking this one, because I think it should be low hanging fruit, therefore I can continue on other issues afterwards.

J08nY commented 8 months ago

This is done via #357