search

crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
9 stars 7 forks source link

Analysis of FIPS references #351

Closed GeorgeFI closed 10 months ago

GeorgeFI commented 11 months ago

This is initial phase of the FIPS reference analysis. In some cases I tried to mirror the CC reference analysis. I also added some extra cells to provide more insights to FIPS references data. I open this PR as draft, because I think I can get much more from the data.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 53.65% and project coverage change: -0.73% :warning:

Comparison is base (4893748) 77.55% compared to head (f352350) 76.82%. Report is 7 commits behind head on main.

:exclamation: Current head f352350 differs from pull request most recent head 749810f. Consider uploading reports for the commit 749810f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ========================================== - Coverage 77.55% 76.82% -0.73% ========================================== Files 52 54 +2 Lines 6592 6694 +102 ========================================== + Hits 5112 5142 +30 - Misses 1480 1552 +72 ``` | [Files Changed](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni) | Coverage Δ | | |---|---|---| | [src/sec\_certs/utils/plot\_utils.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy91dGlscy9wbG90X3V0aWxzLnB5) | `0.00% <0.00%> (ø)` | | | [src/sec\_certs/sample/cc\_certificate\_id.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9zYW1wbGUvY2NfY2VydGlmaWNhdGVfaWQucHk=) | `86.00% <14.29%> (-5.39%)` | :arrow_down: | | [src/sec\_certs/sample/fips.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9zYW1wbGUvZmlwcy5weQ==) | `86.34% <33.34%> (ø)` | | | [src/sec\_certs/dataset/dataset.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9kYXRhc2V0L2RhdGFzZXQucHk=) | `52.45% <80.00%> (+0.23%)` | :arrow_up: | | [src/sec\_certs/utils/profiling.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy91dGlscy9wcm9maWxpbmcucHk=) | `96.56% <96.56%> (ø)` | | | [src/sec\_certs/dataset/cc.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9kYXRhc2V0L2NjLnB5) | `86.78% <100.00%> (+0.21%)` | :arrow_up: | | [src/sec\_certs/dataset/fips.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9kYXRhc2V0L2ZpcHMucHk=) | `92.43% <100.00%> (+0.47%)` | :arrow_up: | | [src/sec\_certs/model/matching.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9tb2RlbC9tYXRjaGluZy5weQ==) | `97.37% <100.00%> (+2.93%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GeorgeFI commented 10 months ago

@adamjanovsky Automatic part of the FIPS analysis is finished from my side and ready for final review.

GeorgeFI commented 10 months ago

Thank you for the review. I will implement the changes by the end of this weekend :)