crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
9 stars 7 forks source link

Wrap CC scheme download in try-except and continue on fail. #371

Closed J08nY closed 8 months ago

J08nY commented 8 months ago

These scheme downloads fail very often, it is better to have just some schemes downloaded rather than to stop the whole download process and throw an exception. This then prevents the updates to go through on the web and means that the data gets stale.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ecc28f7) 75.30% compared to head (0b74398) 75.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #371 +/- ## ========================================== - Coverage 75.30% 75.13% -0.16% ========================================== Files 54 54 Lines 6698 6701 +3 ========================================== - Hits 5043 5034 -9 - Misses 1655 1667 +12 ``` | [Files](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni) | Coverage Δ | | |---|---|---| | [src/sec\_certs/dataset/cc\_scheme.py](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni#diff-c3JjL3NlY19jZXJ0cy9kYXRhc2V0L2NjX3NjaGVtZS5weQ==) | `85.00% <50.00%> (-4.18%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/crocs-muni/sec-certs/pull/371/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crocs-muni)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.