Closed J08nY closed 7 months ago
Attention: 40 lines
in your changes are missing coverage. Please review.
Comparison is base (
be702d4
) 69.36% compared to head (40d89ff
) 68.54%. Report is 13 commits behind head on main.:exclamation: Current head 40d89ff differs from pull request most recent head ec0162c. Consider uploading reports for the commit ec0162c to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Now that this is merged and I did a full run I will use this PR for some insights/issues.
1 1 1
or 2021-02-13
.
The cert-id rules work, but are a mess. This PR will clean them up for presentation in the paper.
Before this, the regular cert_id regexes were used to extract the cert_id from the report filename. However, the filenames often do not use the same cert_id format, but contain all of the information necessary to reconstruct the cert_id, but with different order for example.
This commit along with those before it introduce a new set of regular expressions that better match the ones in the filenames. To extract the correctly formatted canonical cert_id, the regexes are used to obtain the parts of the cert_id (using named groups in regexes) and those are then reconstructed into a canonical version of the cert_id via one of the scheme-dependent functions.