crocs-muni / sec-certs

Tool for analysis of security certificates and their security targets (Common Criteria, NIST FIPS140-2...).
https://sec-certs.org
MIT License
12 stars 8 forks source link

Some maintenance updates missing from `mu_dataset.json` #390

Open adamjanovsky opened 7 months ago

adamjanovsky commented 7 months ago

Describe the bug

Maintenance updates for which either st_link or report_link does not exist are not properly processed by our pipeline. While they are scraped and recorded in the cert.maintenance_updates variable and displayed on Web, they are not further fetched into CCDatasetMaintenanceUpdates object.

This is due to the fact that the members of CCDatasetMaintenanceUpdates constitute a valid CCCertificate for which both st_link and report_link must be of type str. But this is not the case when either is missing, and so the following method disregards them:

https://github.com/crocs-muni/sec-certs/blob/84089f4ec79dfdc537d15be95a4421dd00447764/src/sec_certs/sample/cc_maintenance_update.py#L77