search

crocs-muni / usable-cert-validation

Research initiative to make TLS certificate validation usable.
https://x509errors.org
MIT License
19 stars 3 forks source link

Rename example chains to lowercase #114

Closed zacikpa closed 2 years ago

zacikpa commented 2 years ago

Resolves #103.

zacikpa commented 2 years ago

Oh, I made a silly mistake, do not merge yet.

mukrop commented 2 years ago

Improvement suggestion: You can format the commit message in a way to automatically link it to the issues (and thus automatically closing the issue when merging the pull request). See the relevant GitHub documentation at https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

I've converted the PR back to draft, mark it ready for review and assign me when it's ready.

zacikpa commented 2 years ago

Improvement suggestion: You can format the commit message in a way to automatically link it to the issues (and thus automatically closing the issue when merging the pull request). See the relevant GitHub documentation at https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Oh, I used the wrong keyword in the PR description. Using "resolves" instead of "solves" might have worked.

I've converted the PR back to draft, mark it ready for review and assign me when it's ready.

It's ready now.