Add pages with other libraries

crocs-muni / usable-cert-validation

Research initiative to make TLS certificate validation usable.

https://x509errors.org

MIT License

19 stars 3 forks source link

Add pages with other libraries #87

Closed ericvalcik closed 3 years ago

ericvalcik commented 3 years ago

I've finally created GnuTLS', Botan's, and mbedTLS' own pages with errors. Right now the only things that I've changed are:

I added three new pages with errors of the three mentioned libraries.
In the navbar, I removed the errors dropdown and replaced it with links to the new library pages.
And the title shown on the navbar when scrolled is no longer Usable X.509 errors, but changes to the name of the library.

I've done the sorting of the errors to categories by myself so please take a closer look at these changes, it is highly possible that some errors could have wrong category tags. This PR is mergeable in my opinion.

ericvalcik commented 3 years ago

As I was looking through the PR, I noticed some mistakes and errors. I feel ashamed that I hadn't checked these before submitting the PR. It should be fixed now. Also, there are no linked errors with errors from Botan, GnuTLS, and mbedTLS right now, even when there should be, because some of them are linked by openssl errors. I originally planned to add the mapping in the next PR, but maybe it would be better to add it to this one.

mukrop commented 3 years ago

As fo the mapping, I'm OK for it to be the next PR after finalising this one.

ericvalcik commented 3 years ago

I've done all the requested changes. It's ready for review.

I'm not sure what made you change the padding of sections, but you now break the visual of slightly shaded background (I know, id renders almost invisibly on your device :-/). ((I'll have to darken it a bit :-P.))

I haven't noticed any changes in the background, again 👎 . That's my mistake. I did those changes to move the vertical location of those links to libraries (e.g. #openssl) move a little higher. Without it, when the user was redirected to for example x509errors.org/#openssl, the Time validity errors headline was right under the navbar. Now I found a solution that doesn't affect the visual background changes but does the same thing.

ericvalcik commented 3 years ago

I also deleted botan/CERT_NAME_NO_MATCH.yml, because we already have an error called CERT_NAME_NOMATCH. The deleted error is not present in the Botan source cert_status.cpp we reference on our page.