search

crocs-muni / usable-cert-validation

Research initiative to make TLS certificate validation usable.
https://x509errors.org
MIT License
19 stars 3 forks source link

Drop hardcoded filenames from Python script #89

Closed mukrop closed 3 years ago

mukrop commented 3 years ago

The Python script utils/find_all_linked_errors.py currently has _data/mapping.txt as a hardcoded location (as well as the output directory for mapping files). This is bad practice. Mainly, as it's not transparent that the script uses these locations.

The prefered solution is for example taking the file and output directory as arguments. This way, you would see their usage in Makefile and would not forget to adjust them in case of moving either the input/output files or the script. Note below: I found this as there was a missing dependency in Makefile for the mapping.txt file (the file was modified but Make did not rebuild the mapping). If the file would have been given as an input to the script, it may have been easier not to forget it.

Anyway, this is nothing severe. At some point of doing related stuff (preferebly after the paper deadline :-P), I'd recommend adjusting it.

mukrop commented 3 years ago

We dropped the python script, this issue is no longer relevant.