search

croissantnova / SanityDescentIntoMadness

A Minecraft mod
https://modrinth.com/mod/sanity-descent-into-madness
Other
14 stars 18 forks source link

Simple change that allows PASSIVE_SANITY_SOURCES to be modified. #41

Open QuantumZizo opened 11 months ago

QuantumZizo commented 11 months ago

With the previous way the array "PASSIVE_SANITY_SOURCES" was made, you could not add or remove values from it because it was a fixed size list. This change turns it into a real ArrayList allowing modders to use methods like add() or addAll() on PASSIVE_SANITY_SOURCES in order to add their own sanity sources.

QuantumZizo commented 11 months ago

One more thing to note is that even if this PR is merged for this change to actually become beneficial to modders you'd have to publish a new release on CurseForge that includes this change because from what I know you do not have a Maven where you can put jars for use with Gradle's dependency systems. To get around this I have resorted to using CurseMaven, which produces a dependency based on the current release.