croneter / PlexKodiConnect

Plex integration in Kodi done right
GNU General Public License v2.0
1.18k stars 78 forks source link

Issues replacing an episode with better quality #1871

Closed Mibix closed 1 year ago

Mibix commented 2 years ago

So my server will frequently grab a tv show then sometimes very shortly after grab a replacement for the exact same episode that has better sound or video and it will replace the old file with the new(usually slightly different file name). It will say unable to locate file, want to delete? If you do delete it, that makes it impossible to get it back in to Kodi without a full resync of the plexkodiconnect library so I never chose to do that. Sometimes a perform manual library sync will work to fix this, usually not. If you go to the context menu and play from PMS, like the FAQ says, it doesn't even ask you to pick a version but it will play. After that, you still can't play it normally without the play from PMS option. The only way I've found to fix this is to manually find the file, add a .plexignore to the end of the file extension, wait for it to disappear from plex and Kodi, then remove the file extension, and wait for the file to reappear.

I would expect this to just be able to resync with plex and play the version without need for manual adjustments.

The attached log file is me hitting it when it says it can't locate the file (big sky episode), playing it with the play in PMS from the context menu, trying to play it with two different players in kodi (dsplayer and default). kodi.log

croneter commented 1 year ago

Sorry it took me so long. This is your issue:

10:57:39.315 T:7976   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.AttributeError'>
                                            Error Contents: 'xbmc.Player' object has no attribute 'isExternalPlayer'
                                            Traceback (most recent call last):
                                              File "C:\Users\Mibix\AppData\Roaming\Kodi\addons\plugin.video.plexkodiconnect\resources\lib\kodimonitor.py", line 70, in onNotification
                                                self.PlayBackStart(data)
                                              File "C:\Users\Mibix\AppData\Roaming\Kodi\addons\plugin.video.plexkodiconnect\resources\lib\kodimonitor.py", line 363, in PlayBackStart
                                                status['external_player'] = app.APP.player.isExternalPlayer() == 1
                                            AttributeError: 'xbmc.Player' object has no attribute 'isExternalPlayer'
                                            -->End of Python script error report<--

You seem to be using a "non standard" Kodi installation. I just checked with the latest official Kodi Nexus Release Candidate build from kodi.tv. I cannot replicate your issue. Whatever build of Kodi you're using, it's missing the isExternalPlayer method (source code see here: https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/legacy/Player.cpp). Nothing I can do from my side, sorry.

croneter commented 1 year ago

Solution for you: use a newer Kodi! You're trying a version 17.6. There's a 20 out already!

10:49:01.505 T:13280  NOTICE: Starting Kodi (17.6 Git:20171126-13194ec). Platform: Windows NT x86 64-bit
Mibix commented 1 year ago

Solution for you: use a newer Kodi! You're trying a version 17.6. There's a 20 out already!

10:49:01.505 T:13280  NOTICE: Starting Kodi (17.6 Git:20171126-13194ec). Platform: Windows NT x86 64-bit

This is the newest version with Kodi DSPLayer(MadVR). Newer versions still are terrible with HDR content.

croneter commented 1 year ago

17.6 is way too old, you really should upgrade to Kodi 19

Im using Marven's build e.g. for Dolby Vision-support, check out https://www.kodinerds.net/index.php/Thread/69428-Maven-s-Kodi-Builds-f%C3%BCr-Android/

Mibix commented 1 year ago

17.6 is way too old, you really should upgrade to Kodi 19

Im using Marven's build e.g. for Dolby Vision-support, check out https://www.kodinerds.net/index.php/Thread/69428-Maven-s-Kodi-Builds-f%C3%BCr-Android/

That is for Android not Windows unfortunately