search

croneter / PlexKodiConnect

Plex integration in Kodi done right
GNU General Public License v2.0
1.17k stars 78 forks source link

Feature: SRT subs while transcoding (no burn-in) #1966

Open dlorenzo opened 1 year ago

dlorenzo commented 1 year ago

Render plain subs (SRT external or embedded on mkv files) while the file is being transcoded from 4k to 1080p. Right now, while transcoding, only "burn-in" option is available. On some systems (using a DS920+), hw acceleration is not available for burning in subs so it just won't work if the CPU is not enough. Plex Android application seems to do this just fine. Also, with optimised versions (no transcoding here), external subs don't show up in Kodi (Plex stores them alongside the .mp4 files). Thanks.

croneter commented 1 year ago

Serving SRT subs works, but only if you're NOT transcoding - you need to have set-up Direct Paths correctly. See Set up Direct Paths.

This could be tricky to implement when you're transcoding

dlorenzo commented 1 year ago

Thanks for the reply. Had set up direct paths, and they're working fine, but 4k videos are not being transcoded (nothing is, even if I set 'Force transcode' under playback settings). I set up direct paths under Sync options and then nuke Kodi's database and reload it again. But after this, no way to transcode anything.

What I'm trying to achieve is for 4k HDR videos to be transcoded to 1080p (TV doesn't support them), and keep the ability to display subs as the NAS can't burn them in (can't do it with HW transcoding). Am I missing something? Either I use add-on paths and can transcode but not have subtitles, or use direct paths and can use subtitles but can't transcode (same as using direct play really).

Seems like it was discussed here: https://github.com/croneter/PlexKodiConnect/issues/846 . I can't see how to do it myself. Using 3.8.1.

croneter commented 1 year ago

If you're using Direct Paths, the only way to transcode anything is by using the Kodi context menu, then hit the PKC Settings, then "Force transcode" or "Play via PMS" (PKC then might decide to transcode, depending on your PKC settings). Try that, it might work - I don't remember sorry 😉

dlorenzo commented 1 year ago

Just tried it, but it's back to square 1. It plays, but doesn't recognize subs other than burning them in. My use case would be for videos to be automatically transcoded per the settings (for 4K content) and .mkv with subs to be able to play with .srt subtitles without burning them in.

Curiously enough, if subs are extracted from the video and put alongside the mkv files, they are being shown and rendered just fine without burning them in, using Add-on Paths. Would be cool if this could be extended to embedded subs also.