croneter / PlexKodiConnect

Plex integration in Kodi done right
GNU General Public License v2.0
1.18k stars 78 forks source link

New setting: Allow delaying background sync while playing videos #2039

Closed Spacetech closed 7 months ago

Spacetech commented 8 months ago

This is a follow up on #2027. While that change works, I still want to prevent background sync library refreshes (due to new media being added) from happening while playing videos.

The scheduled full sync code prevents it from running while videos are playing (link). I think we should allow the same for background sync.

Changes:

croneter commented 8 months ago

May I ask: why? I personally never had any issues with the way it's working now

Spacetech commented 8 months ago

The skin I'm using displays a black flash at the top right of the screen when update_kodi_library is called. This even happens while I'm watching something. I think it's trying to indicate a refresh/something progressed, but it's very distracting.

This new setting is defaulting to false, so the existing behavior will remain the same unless someone opt's into it.

croneter commented 7 months ago

Thanks once again!! Merged with https://github.com/croneter/PlexKodiConnect/commit/3bf7ae1fd713fe6ee010dda142a8177c38c9ef25, your new setting now defaults to true :wink: