Make GitHub Actions ensure that cronie keeps compiling without errors on Linux (fixes #174)

hartwork commented 6 months ago

Fixes #174

Four things seem worth mentioning at the moment:

I found multiple licenses used in this repository so I was not sure which one to best apply to these new files. I'll be happy with anything approved by both FSF and OSI, just let me know your preference and I'll apply that. That todo is the key only reason the pull request is marked as a draft at the moment, so it does not get merged by accident.
I would love to use -std=c99 and -Werror but the code would need related fixes first, and I wanted to keep this pull request dedicated to one thing and small enough to be easy to review.
The @v4 in actions/checkout@v4 is not pinning the GitHub Action to a SHA1 only because I seem to be rather alone with being okay with the amount of pull requests that the SHA1-plus-version-comment edition gets you. If it is considered acceptable here, I'm happy to add that pinning bit of extra security, similar to https://github.com/libexpat/libexpat/pull/709 . PS: Yes, Dependabot can still auto-bump dependencies pinned like that (which I find amazing).

I'm happy to answer questions about this pull request and/or discuss adjustment of details :beers:

CC @t8m

t8m commented 6 months ago

As for the license - pick any from the COPYING file that you prefer - or just add a copyright and refer the COPYING file for license.

t8m commented 6 months ago

Otherwise the PR looks good.

hartwork commented 6 months ago

As for the license - pick any from the COPYING file that you prefer - or just add a copyright and refer the COPYING file for license.

@t8m COPYING seems to contain the texts of…

ISC
BSD 2-clause
BSD 3-clause
GPL 2(+)

…and cronie.spec mentions "MIT and BSD and ISC and GPLv2+" (while I cannot find the word MIT anywhere else, on a side note)…

Just referring to COPYING seems troublesome to me so I'll go with approach "pick any from the COPYING file that you prefer" and apply "GPL v2 or later" here then. Pushed, marking as non-draft in a second…

t8m commented 6 months ago

Merged. Thank you for the contribution.

cronie-crond / cronie

Make GitHub Actions ensure that cronie keeps compiling without errors on Linux (fixes #174) #175