search

cronofy / cronofy-node

Node wrapper for the Cronofy API
https://docs.cronofy.com/developers
MIT License
49 stars 23 forks source link

Use axios instead of request #90

Closed gl-aagostino closed 2 years ago

gl-aagostino commented 2 years ago

This PR replaces the deprecated request package with axios. This was primarily created so that this package can run on MongoDB Realm. It may have other related benefits as well.

All tests pass but semistandard throws a lot of warnings so it was circumvented during local testing.

AdamWhittingham commented 2 years ago

Thank you @gl-aagostino!

As this changes such a fundamental dependency, we're going to test it manually against some internal projects just to be absolutely confident, and then we'll merge and release it as soon as we can.

Thanks again - if you'd be interested in some Cronofy goodies as a small token of our appreciation then please drop us an email at support@cronofy.com and we'll arrange to get something to you.

One of the team will be in touch when the new version it out 👍

victor-cronofy commented 2 years ago

@gl-aagostino FYI, new version is published to NPM Registry. Enjoy!