search

cronos-labs / cronos-zkevm

Apache License 2.0
8 stars 3 forks source link

Problem: eth_sender transaction's base fee is not capped #49

Closed thomas-nguy closed 4 months ago

thomas-nguy commented 4 months ago

Solution:

add a cap to base fee

JayT106 commented 4 months ago

Don't understand why caps the base fee in the eth sender, can you give more context? In EIP-1559, there is no definition of the base fee cap but the base fee cannot exceeds the max gas fee.

thomas-nguy commented 4 months ago

Due to an issue on testnet, the l2_gas_price is capped to 10k While this is not an issue for ETH-based chain, it is a big problem for us as zkCRO/ETH exchange rate is 40,000

In some case, the network will not be able to cover its expense so as a prevention measure, we will not allow eth_sender to send l1 transactions when Ethereum gas_price is over 40gwei.

This is the idea of this cap.

JayT106 commented 4 months ago

Due to an issue on testnet, the l2_gas_price is capped to 10k While this is not an issue for ETH-based chain, it is a big problem for us as zkCRO/ETH exchange rate is 40,000

In some case, the network will not be able to cover its expense so as a prevention measure, we will not allow eth_sender to send l1 transactions when Ethereum gas_price is over 40gwei.

This is the idea of this cap.

I see.