search

croogo / docs

Croogo documentation
7 stars 17 forks source link

Push #footer to the bottom of the page. #15

Closed chrisvogt closed 9 years ago

chrisvogt commented 9 years ago

Fixes #14 by pushing the #footer div to the bottom of the page instead of directly under the content. The footer is static, not fixed. Meaning that it will always remain below the content and no content will flow underneath it.

rchavik commented 9 years ago

I'm seeing some strange layout when testing this in my 1366x768 laptop:

docs

Would you be able to address this? I'd really want to fix this too. That footer thing has been bugging me for ages.

chrisvogt commented 9 years ago

I'll take a look at that; it was bugging me too. Is that FireFox on Ubuntu?

chrisvogt commented 9 years ago

I can't seem to reproduce that. Unless you change the default options I assume your Firefox also auto updates, so we should be using the same version. Hmm, do you have any browser extensions loaded that might be injecting into the scripts, styles, or markup?

chrisvogt commented 9 years ago

Chrome, IE, Firefox, Opera on Windows 8.1: windows-tests

Firefox on Ubuntu 14.04: screenshot-ff-ubuntu

rchavik commented 9 years ago

I retried on Firefox 34.0 in safe mode and still seeing the same problem.

Chrome Version 39.0.2171.95 (64-bit) also looks weird:

chrome-docs

Can you help testing on your end by opening a longer page, eg: appendices/2-2-0-migration-guide.html

dakota commented 9 years ago

I can confirm this (Chrome 40)

image

Problem is with long pages, the footer doesn't stay stuck to the bottom, rather it remains at the original position.

chrisvogt commented 9 years ago

Ah, that one doesn't appear right either, but now only on short pages. Setting the height on #main to 100% helps, but then it gets pushed down too far and the page always scrolls. This footer is frustrating, I need to step away from it for a couple hours. I'll give it another shot later and message in when I figure it out.

chrisvogt commented 9 years ago

Looking good now. Also took care of the theme.css and pygments.css assets being double-loaded. (You can see this if you check out the <head> of the production docs right now.)

rchavik commented 9 years ago

I'll pull this in this weekend.

Thank you so much ! :beers:

rchavik commented 9 years ago

This is now merged and in production.

I apologize for the delay.

Thank you!

chrisvogt commented 9 years ago

Looking good! :+1: