search

crooks / PyClean

A Usenet spamfilter written in Python
GNU General Public License v3.0
4 stars 4 forks source link

pyClean uses bad_subject checking only on Dizum posts #15

Open jrehmer opened 11 months ago

jrehmer commented 11 months ago

I don't know if this was an oversight meant to be more of a local preference, but it seems wrong that the bad_subject filter is targeting only posts from Dizum. It's a very useful filter for various types of common spam and limiting it to posts originating from Dizum seems rather silly to me. I didn't realize the targeting until I was troubleshooting why a bunch of spam was getting through that I knew shouldn't be based on my bad_subject entries.

# Bad subject checking (Currently only on Dizum posts).
        if dizum and 'bad_subject' in self.etc_re and not gph:

I changed mine to:

# Bad subject checking.
        if 'bad_subject' in self.etc_re and not gph:

Might be helpful to others to make that change?