search

crops / poky-container

A container image that is able to run bitbake/poky. It has helpers to create users and groups within the container. This is so that the output generated in the container will be readable by the user on the host.
GNU General Public License v2.0
214 stars 96 forks source link

distro-entry.sh: remove hardcoded SDK release number #108

Open WallaceIT opened 4 months ago

WallaceIT commented 4 months ago

Remove the hardcoded Poky SDK release number from the distro-entry.sh script, which will select automatically the environment setup script with the higher release version in its path.

moto-timo commented 3 months ago

You are assuming that the Poky SDK is already installed on the host. This is not the case for the GitHub Actions build automation which creates these containers. The automation MUST continue to work with very little human intervention.

Please consider refactoring to allow a default value and an option to replace with a desired value on the command line instead.

For example RELEASE="${RELEASE:-5.0}"

WallaceIT commented 3 months ago

Hi,

distro-entry.sh is used as entrypoint inside the container, and at the moment is only activates the Poky SDK if a specific version (4.1) is found. The idea behind the PR is to make this mechanism generic and thus decouple from the SDK version that may be installed inside the base image (considering for example crops/poky images, this is true only for a subset of available images). This would allow to change the base image(s) - e.g. changing the SDK version - without impacting the functionality of this repo.

Given all this, I'm not sure I'm following the remark behind the Github Actions automation, as the proposed change shouldn't affect the way in which the build host works - but I'm not an expert in Github CI, so I may have missed something.

Thanks for the review!