search

crops / yocto-dockerfiles

This repository is for -base and -builder containers for building derivative containers (such as poky-container) for containerized Yocto Project builds.
GNU General Public License v2.0
145 stars 57 forks source link

Use buildx to build multi architecture images #104

Closed austinhallett closed 3 months ago

austinhallett commented 3 months ago

Note this PR is still a WIP but I did notice that there was another PR wit a similar goal opened here https://github.com/crops/yocto-dockerfiles/pull/86#ref-commit-211f823 I am wondering if the team prefers to use the shell script, or the gha workflow.

At the end of the day, I do not personally care how I get arm containers, but I am in dire need. Let me know how I can assist in moving this effort forward.

moto-timo commented 3 months ago

Note this PR is still a WIP but I did notice that there was another PR wit a similar goal opened here #86 (reference) I am wondering if the team prefers to use the shell script, or the gha workflow.

At the end of the day, I do not personally care how I get arm containers, but I am in dire need. Let me know how I can assist in moving this effort forward.

In the history of this project, we have already switched from Travis CI to GitHub Actions. We expect the project to live beyond GitHub Actions to the next shiny thing. The way to avoid that vendor lock-in is with the shell scripts.

moto-timo commented 3 months ago

Please please please stop making the whitespace changes. It is extremely difficult to review.

moto-timo commented 3 months ago

I will not proceed with review until you squash the commits and remove the whitespace changes. Make sure you are enabling GitHub Actions on your fork and that you are testing the workflow.