search

crops / yocto-dockerfiles

This repository is for -base and -builder containers for building derivative containers (such as poky-container) for containerized Yocto Project builds.
GNU General Public License v2.0
147 stars 56 forks source link

Add git-lfs Large File Storage support #40

Open moto-timo opened 4 years ago

moto-timo commented 4 years ago

"Git Large File Storage (LFS) replaces large files such as audio samples, videos, datasets, and graphics with text pointers inside Git, while storing the file contents on a remote server."

https://git-lfs.github.com/

This is useful when including proprietary pre-built binaries and also when adding virtualization guests, such as Windows as a Guest or Android as a Guest.

Since http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=a2d6792f3a531b557bffaec4387d8e0e4eb3dab0 git-lfs is a non-fatal HOST_TOOLS addition, meaning it will be linked if present.

debian-9 only supports it with stretch-backports, so skip opensuse-15.0,-15.1 do not have git-lfs except in community packages, so skip ubuntu-16.04 does not have git-lfs except in package cloud, so skip

If someone really wants support in those distro versions, patches are welcome.

Signed-off-by: Tim Orling timothy.t.orling@linux.intel.com

rewitt1 commented 4 years ago

Can this cause any build reproducibility issues between different distros? i.e. Would the behavior be the same between Fedora 29 and Ubuntu 18.04, but not between Fedora 29 and Ubuntu 16.04.

I ask because that was one useful aspect, being able to check for common behavior across distros.

moto-timo commented 4 years ago

@rewitt1 I completely agree about your concern, so the most recent updates to the pull request address debian-9, ubuntu-16.04 and opensuse-15.0,15.1

dkruces commented 3 years ago

Hi guys,

any chance to get this merged? Don't know how busy you are and if I can take over.

rewitt1 commented 3 years ago

Hi guys,

any chance to get this merged? Don't know how busy you are and if I can take over.

I can merge it if it gets updated. But right now, I don't have time to update it myself. I'll circle back in a few weeks when I have more time, and if it hasn't been updated, then I'll try to help out with updating the pull request.

moto-timo commented 3 years ago

Internally we went a different route to add "repo" and "git-lfs" via a derivative container model (which is in the process of being open sourced). The issue with "git-lfs" specifically was that it wasn't directly installable as a package for all the items in the supported Distro/Version matrix. Ergo, I have no motivation to rebase the PR at this time.

Happy to have you take it over @dagmcr if you have a driving need and can bring it up to date. It is possible the Distro/Version package manager issue is no longer a problem (for "git-lfs" specifically).