search

crops / yocto-dockerfiles

This repository is for -base and -builder containers for building derivative containers (such as poky-container) for containerized Yocto Project builds.
GNU General Public License v2.0
145 stars 57 forks source link

Remove install-multilib.sh #91

Closed lgrosz closed 1 year ago

lgrosz commented 1 year ago

Using buildarg TARGETPLATFORM to install multilib where necessary.

I've been thinking about trying to get some cross architecture containers going and would like to fixup the build and deploy scripts and the GitHub workflow to better allow for that.

I chose to use TARGETPLATFORM as a build argument as docker buildx provides it by default, which seems to be the only current option to get build cross-architecture containers. Since this project is only built for the linux/amd64 platform right now, I added that as the only option in the workflow job matrix.

moto-timo commented 1 year ago

Tested local ./buildall.sh and ran into an unrelated debian-9 failure. The CI build for the PR was green. Looks like a reasonable, sensible change.

Would be nice to also test on arm64 host, but my quick test on an M1 Macbook uncovered issues with the find command differences compared to Linux :(

Perhaps I'll spin up an arm64 VM in the cloud and test it there.

moto-timo commented 1 year ago

Just for grins: Build on Ampere arm64 failed for alma-9, centos-7, debian-9, fedora-34 and fedora-35. We should really be bumping to only fedora-36,37,38 based on EOL, so that can be ignored. But this is promising nonetheless.