cropsly / ffmpeg-android-java

Android java library for FFmpeg binary compiled using https://github.com/writingminds/ffmpeg-android
http://writingminds.github.io/ffmpeg-android-java
GNU General Public License v3.0
3.32k stars 831 forks source link

killRunningProcesses is not working #52

Open semir-karic opened 8 years ago

semir-karic commented 8 years ago

i execute the following cmd: -y -i /MY_PATH_IN_VIDEO -strict experimental -vcodec libx264 -preset ultrafast -crf 24 -acodec aac -ar 44100 -ac 2 -b:a 96k -s 320x240 -aspect 4:3 -movflags +faststart /MY_PATH_OUT_VIDEO

and if I call killRunningProcesses nothing happens. The command is still being executed in the background. Is there a fix for this and how can I force stop the cmd execution.

Thanks

ruha9005 commented 8 years ago

It's always return false, because we have this code in FFmpeg.java (in version 0.2.5): @Override public boolean killRunningProcesses() { return Util.killAsync(ffmpegLoadLibraryAsyncTask) && Util.killAsync(ffmpegExecuteAsyncTask); } please, fix it by replacing && with || P.S: why i can't compile 0.2.6 version, in which this error was fixed?

matteinn commented 8 years ago

This has been fixed in 0.2.6. You have to build your own aar file manually.