Set the correct value of 0.0f for D3DRS_POINTSIZE_MIN

crosire / d3d8to9

A D3D8 pseudo-driver which converts API calls and bytecode shaders to equivalent D3D9 ones.

BSD 2-Clause "Simplified" License

927 stars 83 forks source link

Set the correct value of 0.0f for D3DRS_POINTSIZE_MIN #183

Closed WinterSnowfall closed 1 month ago

WinterSnowfall commented 1 month ago

A minor nitpick, though some games may be affected by it in the end.

The default value of D3DRS_POINTSIZE_MIN in D3D9 is 1.0f, whereas it is 0.0f in D3D8:

This needs to be propagated both on device creation and on subsequent device resets.

Besides the documentation hinting at these defaults, I wrote a test to verify them against native d3d8 and d3d9, and they are indeed as stated (thus in need of correction).

crosire commented 1 month ago

Could you add a comment with a brief note why the call is made (as described in this PR), so that it's more obvious to future readers of the code?

WinterSnowfall commented 1 month ago

Sure, can do.