search

cross-platform-actions / action

Cross-platform GitHub action
MIT License
140 stars 19 forks source link

Bad default accelerator #94

Closed Caellian closed 1 week ago

Caellian commented 1 week ago

Version

master (595d543e5d1aeb6d48c0a176965028afe56c7018)

Options

uses: cross-platform-actions/action@master
  with:
    environment_variables: CC=... CXX=... A LOT OF OTHER
    operating_system: openbsd
    architecture: x86-64
    version: 7.6
    shell: bash

Error message

qemu: invalid accelerator hvf

See action output.

jacob-carlborg commented 1 week ago

qemu: invalid accelerator hvf

That's expected behavior. QEMU supports passing multiple accelerators and it will pick the most appropriate. As you can see a couple of lines below [1], it says: qemu: falling back to KVM.

What the actual error seems to be is this: /home/runner/.ssh/config line 6: Invalid environment name. [2]. Sounds to me like there's some environment variable that SSH doesn't like. If you look at what arguments the action is invoked with [3], it's invoked with environment_variables: "$CONTAINER_ENV CC=clang". And CONTAINER_ENV is set as CONTAINER_ENV: "$CONTAINER_ENV CC=clang" [4]. That looks to me like the environment variable CONTAINER_ENV is not expanded.

[1] https://github.com/brndnmtthws/conky/actions/runs/11864790470/job/33068865471?pr=2080#step:7:54 [2] https://github.com/brndnmtthws/conky/actions/runs/11864790470/job/33068865471?pr=2080#step:7:52 [3] https://github.com/brndnmtthws/conky/actions/runs/11864790470/job/33068865471?pr=2080#step:7:3 [4] https://github.com/brndnmtthws/conky/actions/runs/11864790470/job/33068865471?pr=2080#step:7:20

Caellian commented 1 week ago

Alright, thank you for the input and help with /home/runner/.ssh/config line 6: Invalid environment name.. I assumed the fault is with me for that part, thanks for helping with locating it.

The only potential improvement I see for the action with regards to this is throwing an error if possible somehow instead of it being stuck in a loop. Not sure if that's possible, so I'll leave it up to you to open a separate issue.