Closed glehmann closed 6 months ago
ok, I misunderstood what RUN was for — this is happening too often for a single PR!
should be ok for windows too. I've used env -u
to remove the runner config from the env. Just let me know if you prefer a plain script :-)
and I need to look into what is going on with wasm.
The project is more complex than I thought (maybe I've been fooled by how easy it is to use), and this shows in the test suite. I'm curious to see what approach you chose to refactor the test suite in rust. Is it available in a branch?
/ci try
Starting try run. Link to action
The project is more complex than I thought
Yes :D
I'm curious to see what approach you chose to refactor the test suite in rust. Is it available in a branch?
Its nothing concrete right now, basically replace bash with rust, then rewrite it to be prettier, we do have https://github.com/cross-rs/cross/issues/1037 for the bigger issue of actual UI tests
failures look fine, except the wasm one, should probably just exempt it from running this test.
thanks for the kind guidance during the PR!
I'll look at https://github.com/cross-rs/cross-toolchains soon
I'm working on making assert_cmd working with cross.
There is one case a bit more difficult: when using
clear_env()
on a process, orenv -i
, the binary is not able to run anymore because theQEMU_LD_PREFIX
envvar is not set anymore.A (relatively) easy fix might be to ensure in
linux-runner
— and in any other runner — that the necessary environment is configured before running the executable. Something as proposed in this PR foraarch64-unknown-linux-gnu
.Would that be an acceptable solution?
https://github.com/assert-rs/assert_cmd/pull/193