search

cross-rs / cross

“Zero setup” cross compilation and “cross testing” of Rust crates
Apache License 2.0
6.27k stars 357 forks source link

Docs: Change latest to main in dockerfile example #1443

Closed maxpowel closed 4 months ago

maxpowel commented 5 months ago

The tag latest uses a very old image (with very old gcc and glib). The actual "latest" is called main. This little thing cost me several hours and this change will prevent other people to suffer the same.

Emilgardis commented 5 months ago

I'm not sure if this should be merged. The reason is that you should use the tag associated with the cross version you have.

latest = v0.2.5 main/edge = last CI build on main branch

I'd highly recommend you to use FROM $CROSS_BASE_IMAGE instead, documented under this example.

I'd be open to change from latest to 0.2.5, but not to main. I can be persuaded though :D

maxpowel commented 5 months ago

You are right the solution is there, I guess that we can discard this PR then.

But from the point of view of someone new to cross, I would say that for me this part was a bit confusing. FROM $CROSS_BASE_IMAGE is actually what I needed and I in my opinion this is the best and recommended option. Maybe putting first the good solution would help for the new people who are not very sure about what are they doing (like me hehe).

Emilgardis commented 5 months ago

I'm not sure why you changed the base branch for the pr. What I meant with I'd be open to change from latest to 0.2.5, but not to main was using FROM ghcr.io/cross-rs/aarch64-unknown-linux-gnu:0.2.5

Emilgardis commented 4 months ago

I'm closing this PR, if you feel like this should be done please reach out here!