cross-rs / cross

“Zero setup” cross compilation and “cross testing” of Rust crates
Apache License 2.0
6.59k stars 366 forks source link

Could we add gfortran support to our images? #1457

Closed Dirreke closed 5 months ago

Dirreke commented 6 months ago

Checklist

Describe your request

I'm working for a application with many math libs. And gfortran is always required.

It's not difficult to add it. For gnu, Add gfortran-${ARCH}-${SYSTEM}-gnu${ABI} is enough. And for musl, we can add GCC_CONFIG += --enable-languages=c,c++,fortran to musl.sh .

Describe why this would be a good inclusion for cross

It's true that it will increase the size of the docker. But there's always gfortran in the cross-toolchain published by musl.cc or linaro. So I just think if we can add it to our image too. It will make cross docker more complete.

Emilgardis commented 6 months ago

for gnu, is it just a system package? Then couldn't it be done with pre-build?

For musl, I think I'd be fine with just enabling it.

Dirreke commented 6 months ago

Yeah, for gnu it could be done with pre-build. Just want to make it same as musl

Emilgardis commented 6 months ago

I'm fine with adding this to the images, it's in a way a very common compiler, and it's not too large or problematic. Feel free to open a PR making the changes neccessary!