search

cross-rs / cross

“Zero setup” cross compilation and “cross testing” of Rust crates
Apache License 2.0
6.59k stars 365 forks source link

Allow environment variables to contain numbers #1481

Closed pizaCat closed 5 months ago

pizaCat commented 5 months ago

When environment variable pass-through is used, a warning is displayed if the name of the variable contains a number and the value is taken from the host. For example:

[cross] warning: got environment variable of "MY_VAR_AES256" which is not a valid environment variable name. the proper syntax is `passthrough = ["ENVVAR=value"]`

The variable is still passed onto the cross container with the value from the host, but the warning is misleading.

Emilgardis commented 5 months ago

Awesome, good catch. Feel free to add a changelog entry via .changes, altough maybe it's not needed

pizaCat commented 5 months ago

I added the .changes entry, hopefully the filename is ok. It looked like the PR # was used for filename so I did that.